mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 48219: Replaced unportable usage of `time.h` in stout.
Date Fri, 03 Jun 2016 19:35:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48219/
-----------------------------------------------------------

(Updated June 3, 2016, 7:35 p.m.)


Review request for mesos and Michael Park.


Bugs: MESOS-4901
    https://issues.apache.org/jira/browse/MESOS-4901


Repository: mesos


Description
-------

Previously, `duration.hpp` assumed that including <time.h> was
sufficient to ensure that `struct timeval` is defined. Per POSIX,
this is not the case: `struct timeval` is actually defined in
<sys/time.h>. This causes a compilation error on some systems,
notably Alpine Linux.


Diffs
-----

  3rdparty/stout/include/stout/duration.hpp 7a6715059808dd69fd3fde29ff05ecc25a013486 

Diff: https://reviews.apache.org/r/48219/diff/


Testing
-------

`make check` on OSX and recent ArchLinux. Successful compilation on CentOS 6, CentOS 7, Debian
8, Fedora 23, and Ubuntu 12-16.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message