mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 48048: Added documentation for access_sandboxes and access_mesos_logs acls.
Date Wed, 01 Jun 2016 06:26:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48048/#review135770
-----------------------------------------------------------


Fix it, then Ship it!




Looks good. I'll fix these nits and commit it.


docs/authorization.md (line 132)
<https://reviews.apache.org/r/48048/#comment200821>

    s/Mesos own log/Mesos logs/



src/files/files.cpp (line 303)
<https://reviews.apache.org/r/48048/#comment200822>

    s/""/"",/



src/files/files.cpp (line 305)
<https://reviews.apache.org/r/48048/#comment200823>

    s/differetn/different/



src/files/files.cpp (line 308)
<https://reviews.apache.org/r/48048/#comment200824>

    s/authorizer/authorization/


- Adam B


On May 31, 2016, 2:32 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48048/
> -----------------------------------------------------------
> 
> (Updated May 31, 2016, 2:32 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Michael Park.
> 
> 
> Bugs: MESOS-5153
>     https://issues.apache.org/jira/browse/MESOS-5153
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Modifies the file `acls.proto` to take into consideration the added
> authorization actions `access_sandboxes` and `access_mesos_logs`.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md 723d98c859bef04448b105905443d5e7beaa968c 
>   src/files/files.cpp 873664da04d297b52846a9ea95176f96d44c97ab 
> 
> Diff: https://reviews.apache.org/r/48048/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message