mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.
Date Tue, 31 May 2016 19:24:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48084/#review135669
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.hpp (line 1236)
<https://reviews.apache.org/r/48084/#comment200674>

    put `_maintenanceStatus(` on the next line as well.



src/tests/api_tests.cpp (line 207)
<https://reviews.apache.org/r/48084/#comment200677>

    s/stop/setup/ ??
    
    Also can you add a TODO to use v1::master::Call::UPDATE_MAINTENANCE_SCHEDULE when it is
implemented instead of using the old API?



src/tests/api_tests.cpp (line 234)
<https://reviews.apache.org/r/48084/#comment200679>

    s/math expected/matches the expectation/



src/tests/api_tests.cpp (line 235)
<https://reviews.apache.org/r/48084/#comment200680>

    s/statuses/status/


- Vinod Kone


On May 31, 2016, 7:06 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48084/
> -----------------------------------------------------------
> 
> (Updated May 31, 2016, 7:06 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5503
>     https://issues.apache.org/jira/browse/MESOS-5503
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented v1::master::Call::GET_MAINTENANCE_STATUS.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.hpp 0fdda31bb2bdda46d23663379116fb7cc567055a 
>   src/internal/evolve.cpp 4f25f1a892b4834fc4d79b6fd1bd0edd458b7a58 
>   src/master/http.cpp b63d2e09e26f40156e2381a0bb11a8f94e4c4b62 
>   src/master/master.hpp dc0098916e0a55f299c2e1f7e89c6d9d1e7231a3 
>   src/tests/api_tests.cpp 0b6bfadae3a969b3cd1a48e5095e64c953193543 
> 
> Diff: https://reviews.apache.org/r/48084/diff/
> 
> 
> Testing
> -------
> 
> Test on CentOS 7 (gcc 4.8.5)
> 
> ```
> $ ./bin/mesos-tests.sh --gtest_filter="*GetMaintenanceStatus*"
> [==========] Running 2 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 2 tests from ContentType/MasterAPITest
> [ RUN      ] ContentType/MasterAPITest.GetMaintenanceStatus/0
> [       OK ] ContentType/MasterAPITest.GetMaintenanceStatus/0 (203 ms)
> [ RUN      ] ContentType/MasterAPITest.GetMaintenanceStatus/1
> [       OK ] ContentType/MasterAPITest.GetMaintenanceStatus/1 (51 ms)
> [----------] 2 tests from ContentType/MasterAPITest (254 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 2 tests from 1 test case ran. (279 ms total)
> [  PASSED  ] 2 tests.
> ```
> 
> ```
> $ ./bin/mesos-tests.sh --gtest_filter="MasterMaintenanceTest*"
> [==========] Running 11 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 11 tests from MasterMaintenanceTest
> [ RUN      ] MasterMaintenanceTest.UpdateSchedule
> [       OK ] MasterMaintenanceTest.UpdateSchedule (126 ms)
> [ RUN      ] MasterMaintenanceTest.FailToUnscheduleDeactivatedMachines
> [       OK ] MasterMaintenanceTest.FailToUnscheduleDeactivatedMachines (61 ms)
> [ RUN      ] MasterMaintenanceTest.PendingUnavailabilityTest
> [       OK ] MasterMaintenanceTest.PendingUnavailabilityTest (141 ms)
> [ RUN      ] MasterMaintenanceTest.PreV1SchedulerSupport
> [       OK ] MasterMaintenanceTest.PreV1SchedulerSupport (72 ms)
> [ RUN      ] MasterMaintenanceTest.EnterMaintenanceMode
> [       OK ] MasterMaintenanceTest.EnterMaintenanceMode (227 ms)
> [ RUN      ] MasterMaintenanceTest.BringDownMachines
> [       OK ] MasterMaintenanceTest.BringDownMachines (68 ms)
> [ RUN      ] MasterMaintenanceTest.BringUpMachines
> [       OK ] MasterMaintenanceTest.BringUpMachines (69 ms)
> [ RUN      ] MasterMaintenanceTest.MachineStatus
> [       OK ] MasterMaintenanceTest.MachineStatus (53 ms)
> [ RUN      ] MasterMaintenanceTest.InverseOffers
> [       OK ] MasterMaintenanceTest.InverseOffers (120 ms)
> [ RUN      ] MasterMaintenanceTest.InverseOffersFilters
> [       OK ] MasterMaintenanceTest.InverseOffersFilters (284 ms)
> [ RUN      ] MasterMaintenanceTest.EndpointsBadAuthentication
> [       OK ] MasterMaintenanceTest.EndpointsBadAuthentication (63 ms)
> [----------] 11 tests from MasterMaintenanceTest (1288 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 11 tests from 1 test case ran. (1316 ms total)
> [  PASSED  ] 11 tests.
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message