mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <benjamin.mah...@gmail.com>
Subject Re: Review Request 47991: Passed `Request` object by ptr instead of copying it.
Date Tue, 31 May 2016 17:21:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47991/#review135653
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/process.cpp (line 1285)
<https://reviews.apache.org/r/47991/#comment200669>

    We should add a comment here since this is a bit of a hack to avoid copying the request.
Ideally we make it a Shared or Owned when it is received from the decoder.


- Benjamin Mahler


On May 27, 2016, 10:14 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47991/
> -----------------------------------------------------------
> 
> (Updated May 27, 2016, 10:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Michael Park, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change passes the `Request` object by wrapping it in
> `Owned` instead of copying it when forwarding it to `defer`.
> Ideally, this should have been a `unique_ptr`, but our
> `defer` callbacks don't currently support moves.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 988fb3b81259e7b0a6a002f5799d667892874538 
> 
> Diff: https://reviews.apache.org/r/47991/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message