mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 47891: Added RUN_TASK authorization action.
Date Tue, 31 May 2016 09:22:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47891/
-----------------------------------------------------------

(Updated May 31, 2016, 11:22 a.m.)


Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Michael Park.


Changes
-------

Rebased and addressed Adam's comments.


Bugs: MESOS-5459
    https://issues.apache.org/jira/browse/MESOS-5459


Repository: mesos


Description
-------

Authorization requests for RUN_TASK actions can pass `SOME`
authorization object either in a `FrameworkInfo` holding a user, or a
`TaskInfo` with optionally a `CommandInfo` which can optionally hold a
user. If either of these fields is set it will be used as the object;
otherwise an `ANY` type authorization object will be created.

`RUN_TASK` aliases `RUN_TASK_WITH_USER` which becomes deprecated with
0.29.


Diffs (updated)
-----

  include/mesos/authorizer/authorizer.proto 4478bbd3c8f5c1fb862c2c6bd450689d870f7059 
  src/authorizer/local/authorizer.cpp ba523e165a5a4a0a9d1ff94c38431b869d6883e1 
  src/master/master.cpp a6f740f7f71c4b54208e923025d32e0473a65f5e 
  src/tests/authorization_tests.cpp 043365eb14f3eda0d9eda53197c655ab67eacde7 

Diff: https://reviews.apache.org/r/47891/diff/


Testing
-------

Tested on a range of Linux configurations on internal CI.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message