mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomasz Janiszewski <jani...@gmail.com>
Subject Re: Review Request 48051: Expose livereload port in site docker.
Date Tue, 31 May 2016 07:22:45 GMT


> On May 31, 2016, 1:50 a.m., haosdent huang wrote:
> > site/README.md, line 61
> > <https://reviews.apache.org/r/48051/diff/1/?file=1401326#file1401326line61>
> >
> >     @janisz I just test your patch. The livereload gem would bind to "0.0.0.0:35729"
default. In Mac OSX, because docker lauched via a virtualbox vm, "0.0.0.0:35729" is not accessiable
instead of use vm ip and I have to use ssh forwarding in this case. In Ubuntu, it works fine.
> >     
> >     So I think need change this line from
> >     
> >     ```
> >     ssh -NT -L 4567:localhost:4567 <remote-machine>
> >     ```
> >     
> >     to
> >     
> >     ```
> >     ssh -NT -L 4567:localhost:4567 -L 35729:localhost:35729 <remote-machine>
> >     ```
> >     
> >     After execute this in my OSX, that error disappears. XD

Good catch! Let me apply your sugestion.


- Tomasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48051/#review135577
-----------------------------------------------------------


On May 31, 2016, 7:22 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48051/
> -----------------------------------------------------------
> 
> (Updated May 31, 2016, 7:22 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Kevin Klues, Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-5431
>     https://issues.apache.org/jira/browse/MESOS-5431
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Exposing port 35729 is necessary to enable livereload
> provided by middleman-livereload gem.
> 
> 
> Diffs
> -----
> 
>   site/Dockerfile 80e28e96be53909a8c3c1eb3c05dbbc7e698a5a5 
>   site/README.md 91bfd5fff16c7848431bdfc9206f42d18e102ace 
> 
> Diff: https://reviews.apache.org/r/48051/diff/
> 
> 
> Testing
> -------
> 
> Exposing port 35729 is necessary to enable livereload
> provided by `middleman-livereload` gem.
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message