mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 47558: Added `ObjectApprover` interface to `Authorizer`.
Date Tue, 31 May 2016 06:28:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47558/#review135598
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On May 31, 2016, 6:19 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47558/
> -----------------------------------------------------------
> 
> (Updated May 31, 2016, 6:19 a.m.)
> 
> 
> Review request for mesos, Adam B and Michael Park.
> 
> 
> Bugs: MESOS-5403
>     https://issues.apache.org/jira/browse/MESOS-5403
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> With the goal to provide more efficient authorization for multiple,
> potentially large objects, we extend the authorizer interface to support
> `ObjectApprover`. Retrieving an `ObjectApprover` for a given action is
> an asynchronous operation but following authorization of multiple
> objects can be done synchronously without copying.
> 
> NOTE: This implies that `Authorizer` module writers need to ensure that
> an `ObjectApprover` will behave nicely (e.g., it must not block).
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/authorizer.hpp ed5f9e73661e25a83722cf1e408ae61023cd4a21 
>   src/authorizer/local/authorizer.hpp 61388454025211fd7d53e71a86983fd8479950b6 
>   src/authorizer/local/authorizer.cpp 547bbdd6c3605eadd23d2d2717a3fd362a616de5 
>   src/master/http.cpp c8d2f46d9e0ad8a99a6ebffc6a3d5d852cee0616 
>   src/tests/mesos.hpp 041cd42e2aaf5e57d7d575e5f4a97b71c01528b9 
>   src/tests/mesos.cpp 629135f0dc59346f0fcddb2cbe65ca5770fad34e 
> 
> Diff: https://reviews.apache.org/r/47558/diff/
> 
> 
> Testing
> -------
> 
> tested entire chain.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message