mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 47470: Stout: Added `os::temp`.
Date Tue, 31 May 2016 03:38:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47470/#review135581
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/posix/os.hpp (line 462)
<https://reviews.apache.org/r/47470/#comment200612>

    not necessary in this commit.



3rdparty/stout/include/stout/windows/os.hpp (lines 752 - 755)
<https://reviews.apache.org/r/47470/#comment200611>

    I'm guessing this should be `MAX_PATH + 2` as the maximum return value of `GetTempPath`
is `MAX_PATH + 1` which doesn't include the null-terminator.


- Joris Van Remoortere


On May 29, 2016, 9:22 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47470/
> -----------------------------------------------------------
> 
> (Updated May 29, 2016, 9:22 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, and
Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: Added `os::temp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/posix/os.hpp f08604cdd331f0f4394f64ec06a8461f1df6c888

>   3rdparty/stout/include/stout/windows/os.hpp 1363be1d4010028d4fc50242c80d91c0dd53e14c

> 
> Diff: https://reviews.apache.org/r/47470/diff/
> 
> 
> Testing
> -------
> 
> osx: make check
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message