mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 47473: Windows: Added logging for `WSTRINGIFY` calls.
Date Tue, 31 May 2016 00:52:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47473/#review135568
-----------------------------------------------------------


Ship it!




- Joris Van Remoortere


On May 19, 2016, 10:19 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47473/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 10:19 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Joris Van Remoortere, and Michael
Park.
> 
> 
> Bugs: MESOS-5417
>     https://issues.apache.org/jira/browse/MESOS-5417
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The return codes in Windows are not standardized. The function returns
> an empty string and logs a warning.
> 
> 
> Diffs
> -----
> 
>   src/common/status_utils.hpp fa8dbf1958efa13cfd10712a3215dbca693bcff9 
> 
> Diff: https://reviews.apache.org/r/47473/diff/
> 
> 
> Testing
> -------
> 
> OSX: make check
> Windows: build/run
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message