mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Re: Review Request 47990: Added move semantics to `Pipe::write()`.
Date Mon, 30 May 2016 23:21:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47990/
-----------------------------------------------------------

(Updated May 30, 2016, 11:21 p.m.)


Review request for mesos, Benjamin Mahler, Michael Park, and Vinod Kone.


Changes
-------

Added an explicit invariant check to ensure the moved object is not reused


Repository: mesos


Description
-------

Instead of having separate rvalue overload for `write`,
this change takes the sink argument by value
and then does a move. This has the additional small
overhead of performing an extra move.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/http.hpp 10f6fb90e436300bc47f4d5d2ad4beabd19026ba 
  3rdparty/libprocess/src/http.cpp b7839b1402d0660a2461085f5a1db191296e3308 

Diff: https://reviews.apache.org/r/47990/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message