mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <>
Subject Re: Review Request 46003: Removed the default value for agent work_dir.
Date Mon, 30 May 2016 23:18:35 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 30, 2016, 11:18 p.m.)

Review request for mesos, Michael Park and Vinod Kone.


Addresed comments.

Bugs: MESOS-5064

Repository: mesos


The default value for the agent's `--work_dir` flag was removed, the
type of the parameter was changed to `Option<string>`, and code was
added to explicitly set the work directory when necessary.

Diffs (updated)

  src/local/local.cpp c0c2766c9317b53a27eb50f6df1eb6ffd556a4cc 
  src/slave/flags.cpp d3543a019e57658cf60879f40c5f0834a1b8e836 
  src/tests/containerizer/mesos_containerizer_tests.cpp 09742ff21513dc2570684d384b257868dd57a9ce



`sudo make check`


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message