mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 47821: Remove SASL dependency for Windows builds.
Date Mon, 30 May 2016 22:03:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47821/
-----------------------------------------------------------

(Updated May 30, 2016, 10:03 p.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, and Michael
Park.


Bugs: MESOS-5450
    https://issues.apache.org/jira/browse/MESOS-5450


Repository: mesos


Description
-------

SASL is currently a hard dependency for Mesos. Per MESOS-5450, we expect
that some platforms will not support SASL (namely Windows), so this
commit will begin the first step in a several-step process of removing
it as a hard dependency.

For this first step, this commit will shed SASL dependency in libmesos
only for Windows builds. We do this by:

  (1) Adding a preprocessor symbol, `HAS_AUTHENTICATION` that wraps the
      SASL-dependent code, so that we can conditionally choose not to
      compile it.
  (2) Defining `HAS_AUTHENTICATION` on all Unix builds, and leaving it
      undefined on all Windows builds.
  (3) Logging an error and exiting the master if the user passes in
      flags that depend on SASL, such as `--authenticate`.

Notably, what we do *not* do is:

  (1) Shed SASL dependency in the tests.

The impact of this is that, on Windows, relevant libmesos tests will
either not compile, or not pass. Naturally, as tracked by MESOS-5450,
the second phase of this series will be to shed the test dependency as
well.


Diffs (updated)
-----

  cmake/CompilationConfigure.cmake d3a5daee3c4c90712e920136bfe76fc9ab59ec45 
  src/Makefile.am f083cd762d5a070836cb3198897399479b8548c7 
  src/master/master.cpp a6f740f7f71c4b54208e923025d32e0473a65f5e 
  src/sched/sched.cpp 8380e48950f9f9c7919cea6de5236cec8cc1729d 

Diff: https://reviews.apache.org/r/47821/diff/


Testing
-------


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message