mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.
Date Mon, 30 May 2016 21:39:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/#review135549
-----------------------------------------------------------




src/master/master.hpp 
<https://reviews.apache.org/r/48039/#comment200577>

    Though this is currently not necessary, could you please leave a todo here, that after
the deprecation cycle we should introduce this method instead of other two below?



src/master/quota_handler.cpp (line 40)
<https://reviews.apache.org/r/48039/#comment200575>

    Let's add a todo here that this dependency is temporary.



src/master/quota_handler.cpp (line 500)
<https://reviews.apache.org/r/48039/#comment200576>

    Please wrap for consistency.



src/master/quota_handler.cpp (line 533)
<https://reviews.apache.org/r/48039/#comment200578>

    ditto


- Alexander Rukletsov


On May 30, 2016, 1:17 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48039/
> -----------------------------------------------------------
> 
> (Updated May 30, 2016, 1:17 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod Kone, and
Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp eeeccdfdfd296c2a484764e887564f2e065cfd14 
>   src/master/quota_handler.cpp 04639efac8a8b30dbc7cbb2ce5c17d2a88f924b3 
> 
> Diff: https://reviews.apache.org/r/48039/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message