mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.
Date Mon, 30 May 2016 20:36:55 GMT


> On May 30, 2016, 1:22 p.m., Till Toenshoff wrote:
> > src/master/quota_handler.cpp, lines 575-580
> > <https://reviews.apache.org/r/48039/diff/1/?file=1400970#file1400970line575>
> >
> >     Is there a JIRA around introducing LocalAuthorizer specific deprecation cycles
- I would like to understand why we are not pushing this request out to any authorizer (module).

There is no JIRA afaik. In short, the reason why local authorizer is "special" is because
the authorizer interface has been refactored in 0.29 and hence we can simply avoid introducing
enum values corresponding to the quota authz actions being deprecated in 0.29. However, we
still must support related ACLs, which are relevant only to local authorizer. In one sentence:
any authorizer (module) is revamped in 0.29 hence no deprecation is needed, while LocalAuthorizer
should go through deprecation.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/#review135510
-----------------------------------------------------------


On May 30, 2016, 1:17 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48039/
> -----------------------------------------------------------
> 
> (Updated May 30, 2016, 1:17 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod Kone, and
Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp eeeccdfdfd296c2a484764e887564f2e065cfd14 
>   src/master/quota_handler.cpp 04639efac8a8b30dbc7cbb2ce5c17d2a88f924b3 
> 
> Diff: https://reviews.apache.org/r/48039/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message