mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <>
Subject Re: Review Request 48012: Implemented v1::master::Call::GET_FLAGS.
Date Mon, 30 May 2016 01:20:59 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 30, 2016, 1:20 a.m.)

Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.


ben's comments. NNFR.

Bugs: MESOS-2720

Repository: mesos


The idea is to extract JSON::Object representation of flags into a
function that can be used by both the old JSON REST API handler and the
new v1 API handler.

Diffs (updated)

  src/ f1bd5e6e5515535c2aaf9ea8b205f4e8c7096ec5 
  src/internal/evolve.hpp 4d1cb7f2a180f4f4a44491393393449d36ed616b 
  src/internal/evolve.cpp e7afcdb629a509e8bb30ba29542f360066eb8ad4 
  src/master/http.cpp bbbf0a00e486b96e036f59a3107789d0322bc6cd 
  src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 
  src/master/master.cpp 6442762c9fdfa368d5d9d7cd43b97f5addaf7f17 
  src/master/validation.hpp 580f420a72f33290bcbe718bad839084d4209b8c 
  src/master/validation.cpp 982b61da5fe34dbe46190477e75ee7a4e4cdce9c 
  src/tests/api_tests.cpp PRE-CREATION 



make check


Vinod Kone

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message