mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Hindman <b...@berkeley.edu>
Subject Re: Review Request 48016: Implemented v1::master::Call::GET_VERSION.
Date Sun, 29 May 2016 20:19:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48016/#review135450
-----------------------------------------------------------


Ship it!




Ship It!


src/version/version.hpp (line 29)
<https://reviews.apache.org/r/48016/#comment200464>

    Any reason not to just define it here rather than just declare it? With a basic comment:
"A helper for getting the Mesos version."


- Benjamin Hindman


On May 29, 2016, 7:04 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48016/
> -----------------------------------------------------------
> 
> (Updated May 29, 2016, 7:04 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.
> 
> 
> Bugs: MESOS-5479
>     https://issues.apache.org/jira/browse/MESOS-5479
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored version/version.hpp a bit for this.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.cpp e7afcdb629a509e8bb30ba29542f360066eb8ad4 
>   src/master/http.cpp bbbf0a00e486b96e036f59a3107789d0322bc6cd 
>   src/master/main.cpp 25c532c4932dce09c79e1b1c9e2aa4979835f67c 
>   src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 
>   src/slave/main.cpp ecaa7826798e43244e69315cf0a64e486054cafb 
>   src/tests/api_tests.cpp PRE-CREATION 
>   src/version/version.hpp 7bcc66737f8332e72c529d93a885b2c027b8dd2a 
>   src/version/version.cpp 4eb04230bf564160142f09f65282b60f5aec5eeb 
> 
> Diff: https://reviews.apache.org/r/48016/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message