mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Hindman <b...@berkeley.edu>
Subject Re: Review Request 48018: Implemented v1::agent::Call::CHECK_HEALTH.
Date Sun, 29 May 2016 20:17:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48018/#review135448
-----------------------------------------------------------


Ship it!




LGTM barring comments in previous reviews!

- Benjamin Hindman


On May 29, 2016, 7:02 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48018/
> -----------------------------------------------------------
> 
> (Updated May 29, 2016, 7:02 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Kevin Klues.
> 
> 
> Bugs: MESOS-5478
>     https://issues.apache.org/jira/browse/MESOS-5478
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented v1::agent::Call::CHECK_HEALTH.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 64a99d539a0957b92d42c25c8dda298199383018 
>   src/slave/slave.hpp 78a6ecfe29881f1723d7d603a99962afdd5a81a8 
>   src/tests/api_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48018/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message