mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 47999: Added calico information for CNI.
Date Sun, 29 May 2016 06:13:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47999/#review135419
-----------------------------------------------------------




docs/cni.md (line 26)
<https://reviews.apache.org/r/47999/#comment200429>

    Need to add a link to the Calico section over here.



docs/cni.md (line 301)
<https://reviews.apache.org/r/47999/#comment200430>

    Not sure what you mean by an external plugin? The `bridge`, `macvlan`, `ipvlan` and every
CNI plugin is an "external" plugin. I feel this sentence is redundant?



docs/cni.md (line 306)
<https://reviews.apache.org/r/47999/#comment200431>

    All CNI plugins give an IP-per-container, so not requiring to manage port resources is
not specific to calico. For e.g., if the bridge (created using a `bridge` plugin) is attached
to a VLAN or VxLAN, it  would make the IP address allocated to the container routeable too?
    
    Maybe emphasize the fact that Calico is specifically designed to provide private address
spaces to containers/VMs without requiring these networks to rely on NAT to expose services
on these  networks, by making the private address space routeable from the host network using
BGP peering between the the host network and the container network.



docs/cni.md (lines 315 - 339)
<https://reviews.apache.org/r/47999/#comment200432>

    This looks identical to the information provided in
    https://github.com/projectcalico/calico-containers/blob/master/docs/mesos/ManualInstallCalicoCNI.md
    
    So not sure replicating this information here is going to be helpful. 
    
    Maybe give an introduction to calico, and as you have already done give a pointer to the
doucmentation you already have and end it there.



docs/cni.md (line 339)
<https://reviews.apache.org/r/47999/#comment200433>

    It would be nice to see the address space allocation to the container network, the routing
table of the container network, and the routing table of the Agent. 
    
    May be you enhance the documentation at https://github.com/projectcalico/calico-containers/blob/master/docs/mesos/ManualInstallCalicoCNI.md


- Avinash sridharan


On May 28, 2016, 1:27 a.m., Dan Osborne wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47999/
> -----------------------------------------------------------
> 
> (Updated May 28, 2016, 1:27 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added calico information for CNI.
> 
> 
> Diffs
> -----
> 
>   docs/cni.md cdc50da9db2f19f27be6a39f4d6e0f54834fb964 
> 
> Diff: https://reviews.apache.org/r/47999/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Osborne
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message