mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 47942: Windows: Added pipe support functions.
Date Sat, 28 May 2016 21:41:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47942/#review135396
-----------------------------------------------------------




src/slave/containerizer/mesos/posix_pipe.hpp (line 13)
<https://reviews.apache.org/r/47942/#comment200411>

    These are used later for interprocess communication. The comments should be self explanatory.
On Posix most operatrions are noop.


- Alex Clemmer


On May 28, 2016, 9:39 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47942/
> -----------------------------------------------------------
> 
> (Updated May 28, 2016, 9:39 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, and
Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added pipe support functions.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/pipe.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/posix_pipe.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/windows_pipe.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47942/diff/
> 
> 
> Testing
> -------
> 
> OSX: make check
> Windows: build/run
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message