mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 47843: Agent: Added Windows support for launcher/fetcher.cpp.
Date Sat, 28 May 2016 04:19:39 GMT


> On May 25, 2016, 9:02 p.m., Joris Van Remoortere wrote:
> > src/launcher/fetcher.cpp, lines 76-80
> > <https://reviews.apache.org/r/47843/diff/1/?file=1393842#file1393842line76>
> >
> >     can we use the updated `paths::join` here to simplify this?
> >     
> >     Can you add a JIRA to add an OS agnostic helper to quote command line arguments?
This would have simplified this review a LOT :-)

The multiple paths::join is not usable here due to the the added separator.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47843/#review134833
-----------------------------------------------------------


On May 28, 2016, 2:19 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47843/
> -----------------------------------------------------------
> 
> (Updated May 28, 2016, 2:19 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, and
Michael Park.
> 
> 
> Bugs: MESOS-3618
>     https://issues.apache.org/jira/browse/MESOS-3618
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Agent: Added Windows support for launcher/fetcher.cpp.
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp 0539b0182bd4a7178f103dddd1ab4fee8fc79eda 
> 
> Diff: https://reviews.apache.org/r/47843/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message