mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Review Request 47991: Passed `Request` object by ptr instead of copying it.
Date Fri, 27 May 2016 22:14:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47991/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Michael Park, and Vinod Kone.


Repository: mesos


Description
-------

This change passes the `Request` object by wrapping it in
`Owned` instead of copying it when forwarding it to `defer`.
Ideally, this should have been a `unique_ptr`, but our
`defer` callbacks don't currently support moves.


Diffs
-----

  3rdparty/libprocess/src/process.cpp 988fb3b81259e7b0a6a002f5799d667892874538 

Diff: https://reviews.apache.org/r/47991/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message