mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 47150: Implemented new asynchronous docker pre-launch hook.
Date Fri, 27 May 2016 22:07:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47150/
-----------------------------------------------------------

(Updated May 27, 2016, 3:07 p.m.)


Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.


Changes
-------

Renamed hook.  Removed 3 arguments from interface.  Reworked some comments.  Tweaked test.


Bugs: MESOS-5350
    https://issues.apache.org/jira/browse/MESOS-5350


Repository: mesos


Description (updated)
-------

Introduces, but does not fully wire up a new hook.

The new hook, "slavePreLaunchDockerEnvironmentDecorator",
has divergent semantics compared with existing hooks:

* The hook is asynchronous,
* can prevent a task from launching if it errors,
* can overwrite environment variables.

The new hook is intended to be a strictly-superior 
replacement for the existing hook "slavePreLaunchDockerHook".


Diffs (updated)
-----

  include/mesos/hook.hpp 210ffba09f5acae34ca49b888a781f683777f9ca 
  src/examples/test_hook_module.cpp 4b97f84204934d0e678786fd6cde38b89a6f8f48 
  src/hook/manager.hpp 528674e36639fe78137ba0a4bb004c99730e7a22 
  src/hook/manager.cpp 381807d582998043d73e9b8c9d3c1fddbcf73cf1 
  src/tests/hook_tests.cpp c6b4e8a50534e455cf44f427b09f74eef71177b2 

Diff: https://reviews.apache.org/r/47150/diff/


Testing
-------

make check


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message