mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 47942: Windows: Added pipe support functions.
Date Fri, 27 May 2016 06:22:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47942/#review135165
-----------------------------------------------------------



Patch looks great!

Reviews applied: [47052, 47053, 47221, 47054, 41632, 47168, 47169, 47386, 47387, 47388, 47389,
47390, 47391, 47403, 47404, 47409, 47410, 47411, 47412, 47942]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 27, 2016, 4:55 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47942/
> -----------------------------------------------------------
> 
> (Updated May 27, 2016, 4:55 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, and
Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added pipe support functions.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/pipe.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/posix_pipe.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/windows_pipe.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47942/diff/
> 
> 
> Testing
> -------
> 
> OSX: make check
> Windows: build/run
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message