mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 47469: Agent: Added `launch.cpp` to Windows build.
Date Fri, 27 May 2016 06:02:20 GMT


> On May 24, 2016, 11:07 p.m., Joris Van Remoortere wrote:
> > src/slave/containerizer/mesos/launch.cpp, lines 138-146
> > <https://reviews.apache.org/r/47469/diff/1/?file=1385660#file1385660line138>
> >
> >     Are we gaining something specifically on the windows side here?
> >     Is this just mapping the FDs into an abstraction, or are we actually creating
a pipe?
> >     If so, why wasn't that done before?
> 
> Alex Clemmer wrote:
>     The point of using a class was that I wanted to be able to think of a pipe as a pair
of either `HANDLE`s or file descriptors.
>     
>     Daniel will be changing this review up a bit, so I will leave this here for posterity,
but this code will probably change a bit.

What's happening here? The handles used to communicate with the parent are passed as command
line paramters. Those represent handles already in the process handle table. After the fix
the code associates file descriptors to those pipe handles and uses the same code path as
Posix.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47469/#review134656
-----------------------------------------------------------


On May 27, 2016, 5:42 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47469/
> -----------------------------------------------------------
> 
> (Updated May 27, 2016, 5:42 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, and
Michael Park.
> 
> 
> Bugs: MESOS-3624
>     https://issues.apache.org/jira/browse/MESOS-3624
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Agent: Added `launch.cpp` to Windows build.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e0c538d9e6542fbe279bfbf6f20172e4c611c859 
>   src/slave/containerizer/mesos/launch.cpp e22106b014c871e2184a15c2ab154a0674874e47 
> 
> Diff: https://reviews.apache.org/r/47469/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message