mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 47940: Consistent name for UpdateWeights ACL message name.
Date Fri, 27 May 2016 05:45:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47940/
-----------------------------------------------------------

(Updated May 27, 2016, 5:45 a.m.)


Review request for mesos and Adam B.


Changes
-------

Rebased


Repository: mesos


Description
-------

We use singular for the message where applicable.
Note that `UpdateWeights` is not yet included in any release
and hence does not require a deprecation cycle.


Diffs (updated)
-----

  include/mesos/authorizer/acls.proto ace9b698f46e1437911115c82324a87a0d7827fb 
  src/authorizer/local/authorizer.cpp 3c7c791bde65cfcbcc4e319c9ccc487ab37d8029 
  src/tests/dynamic_weights_tests.cpp 362c59aae7b305710d5985bfec28f881be3b64b8 

Diff: https://reviews.apache.org/r/47940/diff/


Testing
-------

make check (OSX)


Thanks,

Joerg Schad


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message