mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 47521: Added creator principal to '/create-volumes' tests.
Date Fri, 27 May 2016 05:37:32 GMT


> On May 26, 2016, 9:40 p.m., Greg Mann wrote:
> > src/tests/persistent_volume_endpoints_tests.cpp, line 1597
> > <https://reviews.apache.org/r/47521/diff/1/?file=1386552#file1386552line1597>
> >
> >     perhaps use a variable for the principal in a subsequent patch?

Added a TODO for this.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47521/#review135079
-----------------------------------------------------------


On May 27, 2016, 5:37 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47521/
> -----------------------------------------------------------
> 
> (Updated May 27, 2016, 5:37 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
>     https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A creator principal is added to the persistent volumes
> used in the PersistentVolumeEndpointsTests.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_endpoints_tests.cpp a57461d881b2bf0175f83b50b0a46167acd5bd3e

> 
> Diff: https://reviews.apache.org/r/47521/diff/
> 
> 
> Testing
> -------
> 
> `make check` was used to test on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message