mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 47940: Consistent name for UpdateWeights ACL message name.
Date Fri, 27 May 2016 05:03:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47940/#review135152
-----------------------------------------------------------



Bad patch!

Reviews applied: [47940]

Failed command: ./support/apply-review.sh -n -r 47940

Error:
2016-05-27 05:03:03 URL:https://reviews.apache.org/r/47940/diff/raw/ [2832/2832] -> "47940.patch"
[1]
error: patch failed: include/mesos/authorizer/acls.proto:221
error: include/mesos/authorizer/acls.proto: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13360/console

- Mesos ReviewBot


On May 27, 2016, 2:44 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47940/
> -----------------------------------------------------------
> 
> (Updated May 27, 2016, 2:44 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We use singular for the message where applicable.
> Note that `UpdateWeights` is not yet included in any release
> and hence does not require a deprecation cycle.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/acls.proto b178f53a299a2941afc073af963f6aff26af1ca8 
>   src/authorizer/local/authorizer.cpp dc53bc4374aea98b5ed41ade5617374d2447229b 
>   src/tests/dynamic_weights_tests.cpp 362c59aae7b305710d5985bfec28f881be3b64b8 
> 
> Diff: https://reviews.apache.org/r/47940/diff/
> 
> 
> Testing
> -------
> 
> make check (OSX)
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message