mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 47528: Updated validation tests with creator principal.
Date Fri, 27 May 2016 04:50:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47528/
-----------------------------------------------------------

(Updated May 27, 2016, 4:50 a.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.


Changes
-------

Addressed comments.


Bugs: MESOS-5005
    https://issues.apache.org/jira/browse/MESOS-5005


Repository: mesos


Description
-------

The master validation tests are updated to include the
new `validate()` signature, and a new test is added,
`CreateOperationValidationTest.NonMatchingPrincipal`,
to ensure that a non-matching creator principal will
be invalidated.


Diffs (updated)
-----

  src/tests/master_validation_tests.cpp ca4442aa1ef0087a7d058d1b3aa430a1dbc16960 

Diff: https://reviews.apache.org/r/47528/diff/


Testing
-------

`make check` was used to test on OSX at the end of this review chain.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message