mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 47903: Removed the unnecessary space in middleman config.rb.
Date Fri, 27 May 2016 02:37:37 GMT


> On May 26, 2016, 6:57 p.m., Tomasz Janiszewski wrote:
> > site/config.rb, line 39
> > <https://reviews.apache.org/r/47903/diff/1/?file=1395618#file1395618line39>
> >
> >     I'm not sure if this change improve anything. Personally I prefer to fix minor
typos like this when there are other changes in file.

Yes, sometimes we sweep update the code which the style is incorrect.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47903/#review135045
-----------------------------------------------------------


On May 26, 2016, 5:06 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47903/
> -----------------------------------------------------------
> 
> (Updated May 26, 2016, 5:06 p.m.)
> 
> 
> Review request for mesos, Tomasz Janiszewski and Vinod Kone.
> 
> 
> Bugs: MESOS-5424
>     https://issues.apache.org/jira/browse/MESOS-5424
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed the unnecessary space in middleman config.rb.
> 
> 
> Diffs
> -----
> 
>   site/config.rb 89179f9eaad1d972b082997afba5ad6102466829 
> 
> Diff: https://reviews.apache.org/r/47903/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message