mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 47215: Changed the dockerized docker command executor CommandInfo usage.
Date Fri, 27 May 2016 00:00:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47215/#review135115
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On May 26, 2016, 2:21 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47215/
> -----------------------------------------------------------
> 
> (Updated May 26, 2016, 2:21 a.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Bugs: MESOS-5350
>     https://issues.apache.org/jira/browse/MESOS-5350
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This changes how we override the `CommandInfo` when launching a 
> dockerized executor; from `shell == true` to `shell = false`.  
> This means that flags are now passed directly rather than as 
> a long string.
> 
> i.e. 
> From: 'mesos-docker-executor --foo="bar" --some="thing"'
> To: [ 'mesos-docker-executor', '--foo=bar', '--some=thing' ]
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp 7af14f4472283ceefd73c06dd8df60af4cf6f7e8 
> 
> Diff: https://reviews.apache.org/r/47215/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message