mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 47522: Added creator principal to persistent volume tests.
Date Thu, 26 May 2016 21:50:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47522/#review135084
-----------------------------------------------------------




src/tests/persistent_volume_tests.cpp (line 32)
<https://reviews.apache.org/r/47522/#comment200079>

    add stout/none.hpp



src/tests/persistent_volume_tests.cpp (lines 1308 - 1310)
<https://reviews.apache.org/r/47522/#comment200073>

    Add a TODO to validate that the correct error is achieved when operations fail.



src/tests/persistent_volume_tests.cpp (line 1390)
<https://reviews.apache.org/r/47522/#comment200074>

    Scope this volume to get rid of the `1` suffix?



src/tests/persistent_volume_tests.cpp (line 1424)
<https://reviews.apache.org/r/47522/#comment200075>

    Provide better names for sched1/2 and driver1/2?



src/tests/persistent_volume_tests.cpp (line 1520)
<https://reviews.apache.org/r/47522/#comment200076>

    Add TODO to validate that correct errors are achieved.



src/tests/persistent_volume_tests.cpp (line 1602)
<https://reviews.apache.org/r/47522/#comment200078>

    Scope this?


- Greg Mann


On May 18, 2016, 8:06 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47522/
> -----------------------------------------------------------
> 
> (Updated May 18, 2016, 8:06 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
>     https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a creator principal to the
> persistent volumes used in the PersistentVolumeTests.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_tests.cpp d246f35046fff469b847c908de2b305ae629212f 
> 
> Diff: https://reviews.apache.org/r/47522/diff/
> 
> 
> Testing
> -------
> 
> `make check` was used to test on OSX at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message