mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 47520: Updated test helpers with creator principal.
Date Thu, 26 May 2016 21:29:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47520/#review135078
-----------------------------------------------------------




src/tests/mesos.hpp (line 522)
<https://reviews.apache.org/r/47520/#comment200064>

    s/creatorPrincipal/principal/


- Greg Mann


On May 18, 2016, 8:04 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47520/
> -----------------------------------------------------------
> 
> (Updated May 18, 2016, 8:04 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
>     https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the `createPersistentVolume` and
> `createDiskInfo` test helper functions to accept an
> argument specifying the creator principal to be included
> in `DiskInfo.Persistence`.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653 
> 
> Diff: https://reviews.apache.org/r/47520/diff/
> 
> 
> Testing
> -------
> 
> `make check` was done on OSX at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message