mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 47515: Enforced a constraint on `DiskInfo.Persistence.principal`.
Date Thu, 26 May 2016 21:12:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47515/#review135064
-----------------------------------------------------------




src/master/master.cpp (line 3742)
<https://reviews.apache.org/r/47515/#comment200041>

    What about just `None()` here?



src/master/validation.cpp (line 823)
<https://reviews.apache.org/r/47515/#comment200044>

    Drop the "A" at the beginning?



src/master/validation.cpp (line 824)
<https://reviews.apache.org/r/47515/#comment200046>

    s/request/operation/
    
    and below



src/master/validation.cpp (line 825)
<https://reviews.apache.org/r/47515/#comment200047>

    Either remove backticks or replace with single quotes?


- Greg Mann


On May 23, 2016, 4:37 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47515/
> -----------------------------------------------------------
> 
> (Updated May 23, 2016, 4:37 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Neil Conway.
> 
> 
> Bugs: MESOS-5005
>     https://issues.apache.org/jira/browse/MESOS-5005
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch enforces the constraint that the principal
> found in `DiskInfo.Persistence` should equal that of
> the framework or operator responsible for creating
> the volume.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 
>   src/master/master.cpp 0c05938de3e4eaeea2187559e81559f85318fa73 
>   src/master/validation.hpp f29f9753c75e5abc3402ed23381edcea26517ab3 
>   src/master/validation.cpp f490b899758bdac9676a6f6939918efa6ac52781 
> 
> Diff: https://reviews.apache.org/r/47515/diff/
> 
> 
> Testing
> -------
> 
> `make check` was used to test on OSX at the end of this review chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message