mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 47470: Stout: Added `os::temp`.
Date Thu, 26 May 2016 13:39:44 GMT


> On May 24, 2016, 11:13 p.m., Joris Van Remoortere wrote:
> > 3rdparty/stout/include/stout/posix/path.hpp, line 19
> > <https://reviews.apache.org/r/47470/diff/1/?file=1385663#file1385663line19>
> >
> >     I don't see why we need this. Can you point to where we use it?
> >     Why is it in a file called `path`?

See follow-up comment from Joris below.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47470/#review134657
-----------------------------------------------------------


On May 26, 2016, 1:38 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47470/
> -----------------------------------------------------------
> 
> (Updated May 26, 2016, 1:38 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, and
Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stout: Added `path::temp_path`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/posix/os.hpp 0f71f66d3efed7513ce407dde5b56368747c8e70

>   3rdparty/stout/include/stout/windows/os.hpp 261768eace6ab09956f4a80e1ec5dba988d831e1

> 
> Diff: https://reviews.apache.org/r/47470/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message