mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 47865: Sorted values of the enums authorization::Action and ACLs.
Date Thu, 26 May 2016 01:09:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47865/
-----------------------------------------------------------

(Updated May 26, 2016, 3:09 a.m.)


Review request for mesos and Adam B.


Summary (updated)
-----------------

Sorted values of the enums authorization::Action and ACLs.


Bugs: MESOS-5153
    https://issues.apache.org/jira/browse/MESOS-5153


Repository: mesos


Description
-------

Unsorted entries in an enum could cause confusion for developers
writing code agains the enum and/or when introducing new values.


Diffs (updated)
-----

  include/mesos/authorizer/acls.proto b178f53a299a2941afc073af963f6aff26af1ca8 
  include/mesos/authorizer/authorizer.proto 911a2271211249a41c4467f6754e9996f640bf38 

Diff: https://reviews.apache.org/r/47865/diff/


Testing
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message