mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 47536: Agent: Added Windows isolators.
Date Tue, 24 May 2016 23:27:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47536/#review134660
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/filesystem/posix.cpp (line 130)
<https://reviews.apache.org/r/47536/#comment199510>

    Why?
    What about the code below isn't supported on windows?



src/slave/containerizer/mesos/isolators/filesystem/windows.hpp (lines 31 - 38)
<https://reviews.apache.org/r/47536/#comment199511>

    Can you explain what we are accomplishing here by making this proxy?


- Joris Van Remoortere


On May 19, 2016, 2:50 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47536/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 2:50 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, and
Michael Park.
> 
> 
> Bugs: MESOS-3619, MESOS-3620 and MESOS-3683
>     https://issues.apache.org/jira/browse/MESOS-3619
>     https://issues.apache.org/jira/browse/MESOS-3620
>     https://issues.apache.org/jira/browse/MESOS-3683
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Agent: Added Windows isolators.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e0c538d9e6542fbe279bfbf6f20172e4c611c859 
>   src/Makefile.am 447bc2ab511ad173d3d911be10992be0974f4584 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.hpp c6cea98e16f2bdea2da0220c235468080bbcd17b

>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 01c0ad6dbb6d509e62e769365586b3d23dcb240d

>   src/slave/containerizer/mesos/isolators/filesystem/windows.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/posix.hpp 227505a70a440f15e68ac001878bcf25610db45f

>   src/slave/containerizer/mesos/isolators/windows.hpp PRE-CREATION 
>   src/usage/main.cpp 7777731acb69900b6fc2bb7bd19cccd78aafb0cc 
>   src/usage/usage.hpp 2e1996a78c617c2559ef882ebede5c8aab6f899f 
>   src/usage/usage.cpp 3b19682e67372b81484eacddbab78c2e5eda3c5b 
> 
> Diff: https://reviews.apache.org/r/47536/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message