mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joris Van Remoortere <joris.van.remoort...@gmail.com>
Subject Re: Review Request 47469: Agent: Added `launch.cpp` to Windows build.
Date Tue, 24 May 2016 23:07:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47469/#review134656
-----------------------------------------------------------




src/CMakeLists.txt (line 259)
<https://reviews.apache.org/r/47469/#comment199502>

    Why here as opposed to alphabetical?



src/slave/containerizer/mesos/launch.cpp (lines 138 - 146)
<https://reviews.apache.org/r/47469/#comment199503>

    Are we gaining something specifically on the windows side here?
    Is this just mapping the FDs into an abstraction, or are we actually creating a pipe?
    If so, why wasn't that done before?


- Joris Van Remoortere


On May 17, 2016, 4:02 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47469/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 4:02 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, and
Michael Park.
> 
> 
> Bugs: MESOS-3624
>     https://issues.apache.org/jira/browse/MESOS-3624
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Agent: Added `launch.cpp` to Windows build.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e0c538d9e6542fbe279bfbf6f20172e4c611c859 
>   src/slave/containerizer/mesos/launch.cpp e22106b014c871e2184a15c2ab154a0674874e47 
> 
> Diff: https://reviews.apache.org/r/47469/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message