mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kapil Arya <ka...@mesosphere.io>
Subject Re: Review Request 47150: Implemented new asynchronous docker pre-launch hook.
Date Tue, 24 May 2016 03:38:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47150/#review134505
-----------------------------------------------------------




include/mesos/hook.hpp (line 112)
<https://reviews.apache.org/r/47150/#comment199368>

    Can we replace `name` with something more explicit/precise?



include/mesos/hook.hpp (line 116)
<https://reviews.apache.org/r/47150/#comment199374>

    I wonder if we should force the module to use `Environment` and internally use `map` if
needed?



src/examples/test_hook_module.cpp (line 188)
<https://reviews.apache.org/r/47150/#comment199367>

    s/an/a/



src/examples/test_hook_module.cpp (line 202)
<https://reviews.apache.org/r/47150/#comment199369>

    It could be my screen, but could you double-check the alignment here?


- Kapil Arya


On May 10, 2016, 10:13 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47150/
> -----------------------------------------------------------
> 
> (Updated May 10, 2016, 10:13 p.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Bugs: MESOS-5350
>     https://issues.apache.org/jira/browse/MESOS-5350
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduces, but does not fully wire up a new hook.
> 
> The new hook, "slavePreLaunchDockerEnvironmentDecoratorAndValidator",
> has divergent semantics compared with existing hooks:
> 
> * The hook is asynchronous,
> * can prevent a task from launching if it errors,
> * can overwrite environment variables.
> 
> 
> Diffs
> -----
> 
>   include/mesos/hook.hpp 210ffba09f5acae34ca49b888a781f683777f9ca 
>   src/examples/test_hook_module.cpp 4b97f84204934d0e678786fd6cde38b89a6f8f48 
>   src/hook/manager.hpp 528674e36639fe78137ba0a4bb004c99730e7a22 
>   src/hook/manager.cpp 381807d582998043d73e9b8c9d3c1fddbcf73cf1 
>   src/tests/hook_tests.cpp 60d52c5849ba555f6f3070883d87aadf105f05b0 
> 
> Diff: https://reviews.apache.org/r/47150/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message