mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kapil Arya <ka...@mesosphere.io>
Subject Re: Review Request 47213: Added FlagsBase::toVector method as an alternative to stringify(flags).
Date Tue, 24 May 2016 03:17:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47213/#review134502
-----------------------------------------------------------


Ship it!





3rdparty/stout/include/stout/flags/flags.hpp (line 1027)
<https://reviews.apache.org/r/47213/#comment199366>

    Just curious, will it do the right thing for boolean flags such as `--quiet`, `--no-quiet`,
`--version` and `--no-version`?


- Kapil Arya


On May 16, 2016, 2 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47213/
> -----------------------------------------------------------
> 
> (Updated May 16, 2016, 2 p.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Bugs: MESOS-5350
>     https://issues.apache.org/jira/browse/MESOS-5350
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `stringify(flags)` will return a version of the flags that can be passed
> through `/bin/sh` for execution.  This method returns the same flags,
> but in a more `exec`-friendly form.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/flags/flags.hpp 91542f56431579be8a3da5ec6e3e58f68e7dfcbe

> 
> Diff: https://reviews.apache.org/r/47213/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message