mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jojy Varghese <j...@mesosphere.io>
Subject Re: Review Request 45949: Implemented docker config get credential helper.
Date Mon, 23 May 2016 22:52:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45949/#review134469
-----------------------------------------------------------




src/docker/spec.cpp (line 162)
<https://reviews.apache.org/r/45949/#comment199300>

    Would reference do? Say, `config&`?



src/docker/spec.cpp (line 169)
<https://reviews.apache.org/r/45949/#comment199298>

    Do we care about just `contains` or does the string have an expected mimimum structure
(say, `startswith` for example).



src/docker/spec.cpp (line 185)
<https://reviews.apache.org/r/45949/#comment199302>

    s/encode/encoded ?


- Jojy Varghese


On May 23, 2016, 9:51 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45949/
> -----------------------------------------------------------
> 
> (Updated May 23, 2016, 9:51 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4938
>     https://issues.apache.org/jira/browse/MESOS-4938
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented docker config get credential helper.
> 
> 
> Diffs
> -----
> 
>   include/mesos/docker/spec.hpp 2ebacc70d92a593c8dd006b34519c3a2a5225481 
>   src/docker/spec.cpp ac28331a17edb8c2ff81d5a2f79a794f869a3e5d 
> 
> Diff: https://reviews.apache.org/r/45949/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message