mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 45952: Implemented support for passing agent default docker config.
Date Mon, 23 May 2016 22:00:13 GMT


> On April 11, 2016, 12:37 a.m., Guangya Liu wrote:
> > src/uri/fetchers/docker.cpp, lines 323-325
> > <https://reviews.apache.org/r/45952/diff/1/?file=1337596#file1337596line323>
> >
> >     Does there are any document change for this?

Unfortunately, we dont have document for docker fetcher yet.


> On April 11, 2016, 12:37 a.m., Guangya Liu wrote:
> > src/uri/fetchers/docker.cpp, line 636
> > <https://reviews.apache.org/r/45952/diff/1/?file=1337596#file1337596line636>
> >
> >     Add a log here to identify that the fetcher is now using auth to fetch the image?
> 
> Guangya Liu wrote:
>     Adding the log in `getCredential` may be better, post some comments in https://reviews.apache.org/r/45949/
, please check. Thanks.

Thanks for the comments, Guangya! Seems like we dont have any log in docker fetcher.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45952/#review128078
-----------------------------------------------------------


On May 23, 2016, 2:52 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45952/
> -----------------------------------------------------------
> 
> (Updated May 23, 2016, 2:52 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4938
>     https://issues.apache.org/jira/browse/MESOS-4938
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented support for passing agent default docker config.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp eeec94326a4fd67675df10e0b6a32267e555fa96

>   src/uri/fetchers/docker.hpp c855a2b55a07bb398f7547b44a85b8ba2d2b2ec3 
>   src/uri/fetchers/docker.cpp ab8f5e05758b7de2573605c81ac80e656bb1db24 
> 
> Diff: https://reviews.apache.org/r/45952/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Tested with mesos-execute, using a private repo from docker hub. Both cases are tested:
> 1. --docker_registry=private_registry
> 2. private_registry/repo
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message