mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.
Date Mon, 23 May 2016 17:29:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47719/#review134395
-----------------------------------------------------------


Ship it!




Looks good.  Just curous -- how did you upload the pictures to the testing section?  Is there
someway to make them smaller next time?

- Kevin Klues


On May 23, 2016, 4:56 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47719/
> -----------------------------------------------------------
> 
> (Updated May 23, 2016, 4:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-5157
>     https://issues.apache.org/jira/browse/MESOS-5157
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed invalid gpu statistics columns in framework data tables.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/agent.html 2f40034cf89e5f92ace3043578881b7b7157e25f 
>   src/webui/master/static/agent_framework.html 4d61c144ffbc51b9855e4b9f9cd99c0bbb1d35a5

> 
> Diff: https://reviews.apache.org/r/47719/diff/
> 
> 
> Testing
> -------
> 
> # For apgent framework page:
> ## Before:
> ![](https://issues.apache.org/jira/secure/attachment/12805672/incorrect_agent_framework_page.png)
> ## After:
> ![](https://issues.apache.org/jira/secure/attachment/12805670/after_agent_framework_page.png)
> 
> # For agent page:
> ## Before:
> ![](https://issues.apache.org/jira/secure/attachment/12805673/incorrect_agent_page.png)
> ## After:
> ![](https://issues.apache.org/jira/secure/attachment/12805671/after_agent_page.png)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message