mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <>
Subject Re: Review Request 47403: Stout: Set `_fmode` to binary in `protobuf.hpp`.
Date Mon, 23 May 2016 12:39:37 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 23, 2016, 12:39 p.m.)

Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, and Michael

Bugs: MESOS-3443 and MESOS-3658

Repository: mesos


In Windows, the I/O subsystem will automatically convert linefeed
endings if the I/O is done on "text" files. For binary files, this
effect is almost never desirable.

This commit will turn of these conversions for protobuf I/O operations.

Diffs (updated)

  3rdparty/stout/include/stout/protobuf.hpp eb4ac8cd738859a119f4f64bf52ae49a5bbef899 




Alex Clemmer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message