mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 47403: Stout: Set `_fmode` to binary in `protobuf.hpp`.
Date Mon, 23 May 2016 12:39:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47403/
-----------------------------------------------------------

(Updated May 23, 2016, 12:39 p.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, and Michael
Park.


Bugs: MESOS-3443 and MESOS-3658
    https://issues.apache.org/jira/browse/MESOS-3443
    https://issues.apache.org/jira/browse/MESOS-3658


Repository: mesos


Description
-------

In Windows, the I/O subsystem will automatically convert linefeed
endings if the I/O is done on "text" files. For binary files, this
effect is almost never desirable.

This commit will turn of these conversions for protobuf I/O operations.


Diffs (updated)
-----

  3rdparty/stout/include/stout/protobuf.hpp eb4ac8cd738859a119f4f64bf52ae49a5bbef899 

Diff: https://reviews.apache.org/r/47403/diff/


Testing
-------


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message