mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 47708: Rearranged `expectedOffers` in the SlavesEndpointFullResources Test.
Date Mon, 23 May 2016 02:58:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47708/#review134299
-----------------------------------------------------------



Patch looks great!

Reviews applied: [47706, 47707, 47708]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1
MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 23, 2016, 12:46 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47708/
> -----------------------------------------------------------
> 
> (Updated May 23, 2016, 12:46 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Neil Conway.
> 
> 
> Bugs: MESOS-5256
>     https://issues.apache.org/jira/browse/MESOS-5256
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change was required in response to the new refactoring for
> resource enumeration. Since resources are now enumerated in a slightly
> different order, the resulting JSON representing resources has a
> slightly different ordering as well.
> 
> NOTE: We don't actually care about the ordering for this test. We only
> care that the resulting resources match. For now we just fix the
> ordering of resources in the JSON string, but we should consider
> updating the test to compare the resulting `Resources` object
> represented by the JSON, not the exact JSON strings themselves.
> 
> 
> Diffs
> -----
> 
>   src/tests/persistent_volume_endpoints_tests.cpp a57461d881b2bf0175f83b50b0a46167acd5bd3e

> 
> Diff: https://reviews.apache.org/r/47708/diff/
> 
> 
> Testing
> -------
> 
> make -j check
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message