> On Mayo 22, 2016, 5:26 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 134
> > <https://reviews.apache.org/r/45668/diff/7/?file=1390779#file1390779line134>
> >
> > Shouldn't this be "--" instead of "__" ?
> >
> > # Replace "--" with "-D".
> > CONFIGURATION=${CONFIGURATION//--/-D}
We have just replaced all "-" with "_" in the previous step.
> On Mayo 22, 2016, 5:26 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 129
> > <https://reviews.apache.org/r/45668/diff/7/?file=1390779#file1390779line129>
> >
> > # Remove "\".
> > CONFIGURATION=${CONFIGURATION//\/}
> >
> > Do we have back slashes in configuration?
You are right. The backslashes appear in "echo" commands (like in "echo ENV DISTCHECK_CONFIGURE_FLAGS
''\''--verbose'\''' ''\''--enable_libevent'\'''"), but there is no need of replacing them.
> On Mayo 22, 2016, 5:26 p.m., Vinod Kone wrote:
> > support/docker_build.sh, line 126
> > <https://reviews.apache.org/r/45668/diff/7/?file=1390779#file1390779line126>
> >
> > Don't think we need to have the `replace` variable. Just use the replacement
strings inline.
> >
> > Also need periods at the end of comments and quotes around literals.
> >
> > # Remove "'".
> > CONFIGURATION=${CONFIGURATION//\'/}
I have always used a variable. Nice to note that it can be done directly inline.
- Juan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45668/#review134277
-----------------------------------------------------------
On Mayo 22, 2016, 2:10 p.m., Juan Larriba wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45668/
> -----------------------------------------------------------
>
> (Updated Mayo 22, 2016, 2:10 p.m.)
>
>
> Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone.
>
>
> Bugs: MESOS-5101
> https://issues.apache.org/jira/browse/MESOS-5101
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enable CMake build
>
>
> Diffs
> -----
>
> support/docker_build.sh 28ef4dce3f473adab9919d4c2170075a0900af41
>
> Diff: https://reviews.apache.org/r/45668/diff/
>
>
> Testing
> -------
>
> Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both cmake and autotools.
In ubuntu:14.04 was built using gcc and clang, in centos:7 only gcc.
>
>
> Thanks,
>
> Juan Larriba
>
>
|