> On May 21, 2016, 4:45 a.m., Adam B wrote:
> > include/mesos/authorizer/authorizer.hpp, lines 39-40
> > <https://reviews.apache.org/r/47558/diff/3/?file=1387497#file1387497line39>
> >
> > Does `filter()==true` mean that the subject is authorized for the object? Or
does it mean that the object has been filtered out? This is a confusing name for me. Please
at least comment.
changed it to ObjectAllower. I hope allow is an easier to understand semantic.
> On May 21, 2016, 4:45 a.m., Adam B wrote:
> > include/mesos/authorizer/authorizer.hpp, lines 47-53
> > <https://reviews.apache.org/r/47558/diff/3/?file=1387497#file1387497line47>
> >
> > Would it be possible to only filter at the Framework/Executor level in 0.29,
so we don't have to worry about TaskInfo vs. Task?
In master the datastructure holding Tasks is `Framework`. Hence we cannot really filter tasks
using just ExecutorInfo (as we don't have access to it).
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47558/#review134232
-----------------------------------------------------------
On May 21, 2016, 3:47 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47558/
> -----------------------------------------------------------
>
> (Updated May 21, 2016, 3:47 p.m.)
>
>
> Review request for mesos, Michael Park and Vinod Kone.
>
>
> Bugs: MESOS-5403
> https://issues.apache.org/jira/browse/MESOS-5403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added filter interface to authorizer.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp ed5f9e73661e25a83722cf1e408ae61023cd4a21
> src/authorizer/local/authorizer.hpp d15d3a6c9f3d7c432e593cfe78cc48d672848d02
> src/authorizer/local/authorizer.cpp aa1a9d8e5c7fb86b6310015d93aeacb466a307ef
> src/tests/mesos.hpp 79bf1ff16412ce2a510a9b75ab1ac91c1c182653
> src/tests/mesos.cpp 849e656c8b85304cccecc9d7b9d9116884132244
>
> Diff: https://reviews.apache.org/r/47558/diff/
>
>
> Testing
> -------
>
> tested entire chain.
>
>
> Thanks,
>
> Joerg Schad
>
>
|