mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kapil Arya <>
Subject Re: Review Request 47123: Added --modules_dir flag to read module manifests from a directory.
Date Fri, 20 May 2016 02:40:45 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 19, 2016, 10:40 p.m.)

Review request for mesos, Cody Maloney and Till Toenshoff.


Fixed compilation error.

Bugs: MESOS-5173

Repository: mesos


This allows the operator to use separate manifest JSON files for each
module.  Previously, one had to merge all module manifest files into a
single JSON file before passing on to the master/agent.

Diffs (updated)

  src/master/flags.hpp d08509667c919e9cfd076762b622c18732edf910 
  src/master/flags.cpp ceb4bd4f863d3857eede8287041a53d66f1c9e4c 
  src/master/main.cpp d00bbef2c4fb74544056ab81aeb4fcd6625b89fa 
  src/module/manager.hpp 9944af0daf6c9cb5a8ff338099401b1db88ee237 
  src/module/manager.cpp 9f88ec3addab59e4a40b0b40612518178d535aa5 
  src/sched/flags.hpp b4ca12b667283cee1f96a4b421fcf3b06bbe59d7 
  src/sched/sched.cpp 9e55885704d5c4a8bc0e25e324b9c65e7bc34798 
  src/slave/flags.hpp 3363412099ca2841e175bd6b6ed3d5f13605e6f0 
  src/slave/flags.cpp 2d59329997197966f7d30d6f1375a988edbceb9c 
  src/slave/main.cpp 13ddfb9ae5a1ca240b738e67391ce5c5fc9ac0b6 
  src/tests/flags.hpp ae232b1a087edfaf678bd1c67bc509efd6c740d8 
  src/tests/main.cpp efec92286c78f7783e1de0781eb9e61c202a4fb8 



Manual testing with:
1. --module_dir
2. --modules
3. --module_dir in conjunction with --modules

The first two succeeded while the third failed as expected.


Kapil Arya

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message