mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 47400: Documentation quota authorization changes in 0.29.
Date Thu, 19 May 2016 04:34:12 GMT


> On May 19, 2016, 3:25 a.m., Guangya Liu wrote:
> > CHANGELOG, line 59
> > <https://reviews.apache.org/r/47400/diff/3/?file=1387106#file1387106line59>
> >
> >     s/set_quotas/`set_quotas`
> >     s/remove_quotas/`remove_quotas`
> >     
> >     s/in/in favor
> >     
> >     Do we need to mention `get_quotas` here?

I don't think we need to mention get_quotas.


> On May 19, 2016, 3:25 a.m., Guangya Liu wrote:
> > CHANGELOG, line 61
> > <https://reviews.apache.org/r/47400/diff/3/?file=1387106#file1387106line61>
> >
> >     I think ` This is applicable to both local authorizer as well as any custom
authorizer module.` can be removed.
> >     
> >     The CHANGELOG only need to clarify the update

Hmm, I'd like to explicitly call it out, unless you see harm here.


> On May 19, 2016, 3:25 a.m., Guangya Liu wrote:
> > docs/upgrades.md, line 175
> > <https://reviews.apache.org/r/47400/diff/3/?file=1387109#file1387109line175>
> >
> >     Why moving this part to quota section?

I'm keeping all bulletpoints with an anchor before ones without.


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47400/#review133865
-----------------------------------------------------------


On May 18, 2016, 4:53 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47400/
> -----------------------------------------------------------
> 
> (Updated May 18, 2016, 4:53 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-5155 and MESOS-5336
>     https://issues.apache.org/jira/browse/MESOS-5155
>     https://issues.apache.org/jira/browse/MESOS-5336
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Documentation quota authorization changes in 0.29.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 6bd59d191a8ca59436fa8a1953587119aeb3e256 
>   docs/authorization.md 9a359dc1c5576e9871c0747d02852bde35d67a3e 
>   docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 
>   docs/upgrades.md 59274362fa6ec1e5857176fd5f8fd78c381f0d52 
> 
> Diff: https://reviews.apache.org/r/47400/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message