mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 47482: Added preliminary support for parsing ELF files in stout.
Date Wed, 18 May 2016 20:20:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47482/
-----------------------------------------------------------

(Updated May 18, 2016, 8:20 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Updated to use `emplace_back()` instead of `push_back()`. Also added utility for getting the
elf::Class associated with the ELF file (e.g. CLASS32 or CLASS64). This is required for some
of the work we are doing with consolidating Nvidia GPU libraries.


Bugs: MESOS-5400
    https://issues.apache.org/jira/browse/MESOS-5400


Repository: mesos


Description
-------

Right now we are able to parse ELF formatted shared libraries and
extract their canonical SONAME and external library dependencies. In
the future, we should add support for fully parsing an ELf file for
easy access to all of its contents.

The current implementation relies on libelf. We should probably remove
this dependency in future versions (mostly since the headers for
libelf are not installed on a standard Linux distribution by default).


Diffs (updated)
-----

  3rdparty/stout/configure.ac ada1e22c72875fe9d557f07e4846128be0bcef13 
  3rdparty/stout/include/stout/elf.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/47482/diff/


Testing (updated)
-------

The test for this is actually in a follow-on patch for testing ld.so.cache parsing. The test
itself is run with:
```
GTEST_FILTER="LdcacheTest.Parse" make check -j
```


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message