mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <>
Subject Re: Review Request 47399: New update_quotas ACL for both set and remove cases.
Date Tue, 17 May 2016 21:11:47 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 17, 2016, 9:11 p.m.)

Review request for mesos, Adam B and Alexander Rukletsov.


Update test done.

Bugs: MESOS-5155

Repository: mesos


New update_quotas ACL for both set and remove cases.


  include/mesos/authorizer/acls.proto b170330b236b83611d8477c0e45e520ef69aed9b 
  include/mesos/authorizer/authorizer.proto 7d4aa32f42de538864508a0ba481d875917d9ab9 
  src/authorizer/local/authorizer.hpp d15d3a6c9f3d7c432e593cfe78cc48d672848d02 
  src/authorizer/local/authorizer.cpp bd47f4f02238e5052d9ab6caf338a2b51ddb752d 
  src/master/master.hpp 22a1538b8c2ca85cb8316aafe3f9a4476df833fc 
  src/master/quota_handler.cpp 86a2e175a3e1932961682c2a2d0cfe8210ee5fd0 
  src/tests/authorization_tests.cpp f50ac69c32d0551a63391d97f31559ff4f414011 
  src/tests/master_quota_tests.cpp 9bfa6ca58d5a92b857e8f2ce5cb835ddf18b44e6 


Testing (updated)

1. Unit tests;
2. Manually tested cases: authorized and forbidden under both deprecated set_quotas/remove_quotas
and new update_quotas, as well as the case that specifying both triggers master crash.


Zhitao Li

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message